Skip to content

chore(internal): add @middy/core license to proejct third-party licenses #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

Following #1225, in which we lifted some types from @middy/core, it has correctly been raised by @saragerion in #1248 that we should add the MIT license to our LICENSE-THIRD-PARTY file for as long as these types/interface are part of our codebase.

This PR does this and will close #1248 once merged.

How to verify this change

See diff.

Related issues, RFCs

Issue number: #1248

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Jan 16, 2023
@dreamorosi dreamorosi linked an issue Jan 16, 2023 that may be closed by this pull request
1 task
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Jan 16, 2023
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 16, 2023
@dreamorosi dreamorosi merged commit fd8de27 into main Jan 16, 2023
@dreamorosi dreamorosi deleted the 1248-maintenance-add-middy-license-to-repository-notice branch January 16, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add Middy license to repository notice
1 participant