Skip to content

chore: add Node.js 18 support #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 19, 2022
Merged

chore: add Node.js 18 support #1192

merged 8 commits into from
Dec 19, 2022

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Dec 15, 2022

Description of your changes

As discussed in #1191, AWS Lambda announced support for the nodejs18.x runtime a few weeks ago. This PR introduces the changes necessary to run unit and integration tests on the new runtime, as well as changing the default Node version used for development to Node.js 18.

How to verify this change

See checks under the PR (unit tests) as well as result of integration tests (link to run in the comments below).

Related issues, RFCs

Issue number: #1191

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Dec 15, 2022
@dreamorosi dreamorosi self-assigned this Dec 15, 2022
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Dec 15, 2022
@dreamorosi dreamorosi force-pushed the chore/nodejs18_support branch from 94e261b to aa26799 Compare December 17, 2022 14:34
@pull-request-size pull-request-size bot added size/XL PRs between 500-999 LOC, often PRs that grown with feedback and removed size/L PRs between 100-499 LOC labels Dec 17, 2022
@dreamorosi
Copy link
Contributor Author

@dreamorosi dreamorosi marked this pull request as ready for review December 19, 2022 14:26
@dreamorosi dreamorosi linked an issue Dec 19, 2022 that may be closed by this pull request
2 tasks
@dreamorosi dreamorosi merged commit 999a86c into main Dec 19, 2022
@dreamorosi dreamorosi deleted the chore/nodejs18_support branch December 19, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XL PRs between 500-999 LOC, often PRs that grown with feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add support for nodejs18x runtime
1 participant