Skip to content

Maintenance: rename Tracer's folder to "packages/tracer" #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saragerion opened this issue May 9, 2022 · 2 comments · Fixed by #854
Closed

Maintenance: rename Tracer's folder to "packages/tracer" #829

saragerion opened this issue May 9, 2022 · 2 comments · Fixed by #854
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped good-first-issue Something that is suitable for those who want to start contributing internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tracer This item relates to the Tracer Utility
Milestone
production-ready-...

Comments

@saragerion
Copy link
Contributor

saragerion commented May 9, 2022 •
edited
Loading

Bug description

More of a chore than a bug but the Tracer utility is called "Tracer" everywhere except than in the name of its containing folder.
This inconsistency causes annoyance and confusion, especially dealing with Github Actions.

Expected Behavior

Rename the current folder of the Tracer utility from:
packages/tracing
to
packages/tracer

Current Behavior

N/A

Possible Solution

N/A

Steps to Reproduce

N/A

Environment

  • Powertools version used: all
  • Packaging format (Layers, npm): NPM
  • AWS Lambda function runtime: N/A
  • Debugging logs: N/A

Related issues, RFCs

N/A
@saragerion saragerion added bug Something isn't working triage This item has not been triaged by a maintainer, please wait good-first-issue Something that is suitable for those who want to start contributing labels May 9, 2022
@saragerion saragerion mentioned this issue May 9, 2022
Merged
13 tasks
@dreamorosi
Copy link
Contributor

You have no idea how many times I got this wrong lol

Just for documentation purposes, I want to link the issue where we decided this naming convention #26

@dreamorosi dreamorosi self-assigned this May 12, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone May 12, 2022
@dreamorosi dreamorosi mentioned this issue May 12, 2022
Merged
6 tasks
@dreamorosi dreamorosi added tracer This item relates to the Tracer Utility and removed triage This item has not been triaged by a maintainer, please wait labels May 12, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) and removed bug Something isn't working labels Nov 14, 2022
@dreamorosi dreamorosi changed the title Bug (tracer): rename Tracer's folder to "packages/tracer" Maintenance: rename Tracer's folder to "packages/tracer" Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped good-first-issue Something that is suitable for those who want to start contributing internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tracer This item relates to the Tracer Utility
Projects
None yet
Milestone
production-ready-release
Development

Successfully merging a pull request may close this issue.

chore(tracer): rename package folder to tracer aws-powertools/powertools-lambda-typescript
2 participants
@dreamorosi @saragerion