Skip to content

Bug: metrics might not respect the 100 metrics x log limit #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Mar 3, 2022 · 3 comments
Closed

Bug: metrics might not respect the 100 metrics x log limit #616

dreamorosi opened this issue Mar 3, 2022 · 3 comments
Assignees
Labels
metrics This item relates to the Metrics Utility not-a-bug New and existing bug reports incorrectly submitted as bug rejected This is something we will not be working on. At least, not in the measurable future

Comments

@dreamorosi
Copy link
Contributor

Bug description

Opening this issue to firstly investigate if the bug exists in Metrics, then based on result decide on an implementation.

Expected Behavior

Metrics to be able to handle >100 metrics and split them into the appropriate number of logs so to be compliant with the EMF spec.

Current Behavior

Unknown - Investigation needed

Possible Solution

N/A

Steps to Reproduce

  1. Initialise Metrics
  2. Try to put 101 metrics
  3. See what happens

Environment

  • Powertools version used: N/A
  • Packaging format (Layers, npm): N/A
  • AWS Lambda function runtime: N/A
  • Debugging logs: N/A

Related issues, RFCs

#1046

@dreamorosi dreamorosi added bug Something isn't working metrics This item relates to the Metrics Utility triage This item has not been triaged by a maintainer, please wait labels Mar 3, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Mar 3, 2022
@flochaz flochaz self-assigned this May 19, 2022
@saragerion
Copy link
Contributor

This is a nice to have, not a must have for GA.
@flochaz to evaluate how much work this is and based on that evaluate if we can bring in.

@saragerion
Copy link
Contributor

This is already implemented.

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Oct 19, 2022
@dreamorosi dreamorosi changed the title Bug (metrics): metrics might not respect the 100 metrics x log limit Bug: metrics might not respect the 100 metrics x log limit Nov 14, 2022
@dreamorosi dreamorosi added rejected This is something we will not be working on. At least, not in the measurable future not-a-bug New and existing bug reports incorrectly submitted as bug and removed bug Something isn't working labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics This item relates to the Metrics Utility not-a-bug New and existing bug reports incorrectly submitted as bug rejected This is something we will not be working on. At least, not in the measurable future
Projects
None yet
Development

No branches or pull requests

3 participants