-
Notifications
You must be signed in to change notification settings - Fork 153
Docs: code examples for logger and metrics have compile errors. #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Indeed, thx for reporting this, we were planning to potentially remove them since they are duplication of unit tests and global examples. |
Ok. then there is also uploading the Readme, of whether or not to point out these examples or not. Example projects are really handy if they work :) |
The issue with current per package examples as they are today is that they can't really be copied and paste since their imports point to local implementation (for instance: |
Either way the immediate fix is in my PR. |
|
Bug description
Provided code examples have compile errors. And the to the Tracer from the readme is broken
Expected Behavior
Code examples should compile
Current Behavior
Code examples don't all compile
Possible Solution
Fix code examples
Steps to Reproduce
Environment
Related issues, RFCs
The text was updated successfully, but these errors were encountered: