Skip to content

Maintenance: update output generation for e2e #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Apr 23, 2025 · 2 comments · Fixed by #3854
Closed
1 of 2 tasks

Maintenance: update output generation for e2e #3853

dreamorosi opened this issue Apr 23, 2025 · 2 comments · Fixed by #3854
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

The experimental CDK toolkit CLI that we use for our e2e tests has introduced a lock mechanism on the output folder generated by a stack being synthesized.

This conflicts with our current usage that creates a shared folder and generates test-specific output files, thus causing the tests to fail.

Why is this needed?

So that the e2e tests can continue working with the newer version of the experimental CDK toolkit.

Which area does this relate to?

No response

Solution

Update the logic that generates the output folder to be unique for each test.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) triage This item has not been triaged by a maintainer, please wait labels Apr 23, 2025
@dreamorosi dreamorosi added automation This item relates to automation confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Apr 23, 2025
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Apr 23, 2025
@dreamorosi dreamorosi self-assigned this Apr 23, 2025
@dreamorosi dreamorosi linked a pull request Apr 23, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Apr 23, 2025
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Apr 23, 2025
Copy link
Contributor

This is now released under v2.19.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Apr 24, 2025
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant