Skip to content

feat(logger): set correlation ID in Logger #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 14, 2025

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Mar 14, 2025

Summary

Changes

Please provide a summary of what's being changed

This PR adds a new feature to add correlation ID to the logger. As proposed in the issue, customers who don't use this feature won't need to import additional 70kb of code they will not use. Therefore for using this feature, customers need to install our jmespath utility manually and inject it into the logger.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2863


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d self-assigned this Mar 14, 2025
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation logger This item relates to the Logger Utility tests PRs that add or change tests labels Mar 14, 2025
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Mar 14, 2025
@am29d am29d marked this pull request as draft March 14, 2025 09:09
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bit of comments here and there - I see you've made another review in the meanwhile, so a couple of them might now be outdated. If they are you can resolve them.

@am29d am29d marked this pull request as ready for review March 14, 2025 10:37
@am29d am29d requested a review from dreamorosi March 14, 2025 10:47
@am29d am29d requested a review from dreamorosi March 14, 2025 11:59
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the previous comments, the implementation looks good now.

I've left a few minor suggestions on the docs/examples but other than that we're good.

@dreamorosi dreamorosi self-requested a review March 14, 2025 14:39
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, it was one I was personally looking forward to a lot.

Thanks also for the several iterations, appreciate your patience.

@dreamorosi dreamorosi merged commit aa74fc8 into main Mar 14, 2025
41 checks passed
@dreamorosi dreamorosi deleted the issue2863/correlation-id-in-logger branch March 14, 2025 14:41
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Mar 14, 2025
@am29d
Copy link
Contributor Author

am29d commented Mar 14, 2025

Thanks for taking the time and your attention to detail to improve the docs and polish the implementation 💛

@thiagomeireless
Copy link

Thank you for managing that issue @dreamorosi and thank you for working on it so quickly @am29d, great job guys, this project is amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation feature PRs that introduce new features or minor changes logger This item relates to the Logger Utility size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: set correlation ID in Logger
3 participants