-
Notifications
You must be signed in to change notification settings - Fork 153
feat(logger): set correlation ID in Logger #3726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…orrelation ID type definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bit of comments here and there - I see you've made another review in the meanwhile, so a couple of them might now be outdated. If they are you can resolve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the previous comments, the implementation looks good now.
I've left a few minor suggestions on the docs/examples but other than that we're good.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, it was one I was personally looking forward to a lot.
Thanks also for the several iterations, appreciate your patience.
Thanks for taking the time and your attention to detail to improve the docs and polish the implementation 💛 |
Thank you for managing that issue @dreamorosi and thank you for working on it so quickly @am29d, great job guys, this project is amazing! |
Summary
Changes
This PR adds a new feature to add correlation ID to the logger. As proposed in the issue, customers who don't use this feature won't need to import additional 70kb of code they will not use. Therefore for using this feature, customers need to install our jmespath utility manually and inject it into the logger.
Issue number: closes #2863
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.