feat(commons): make utilities aware of provisioned concurrency #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
commons
github-actions
bot
added
the
feature
dreamorosi
force-pushed
the
feat/provisioned_concurrency
branch
from
aeaf638 to
e7c141e
Compare
boring-cyborg
bot
added
the
dependencies
pull-request-size
bot
added
size/L
|
Converted this back to draft because I wanted to extract the e2e test changes, but I'll do it on Monday. |
dreamorosi
force-pushed
the
feat/provisioned_concurrency
branch
from
5436bf3 to
8b934e3
Compare
pull-request-size
bot
added
size/M
|
|
Integration tests are passing: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/13944894973 |
leandrodamascena
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR modifies the logic used to detect cold starts by making it take into account the value of the
AWS_LAMBDA_INITIALIZATION_TYPEenv variable, which can haveon-demandorprovisioned-concurrencyas values according to the environment in which the function is being run.Depending on the value, we either use the original logic (
on-demand) or always default tofalse, meaning not a cold start, when running under provisioned concurrency.This feature allows customers to have traces, logs, and metrics that are more accurate to the environment they're running their functions within.
The PR also introduces a new e2e test suite in Logger that covers some advanced cases that have been introduced in the past weeks, including this one:
Here's an example of a passing run: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/13862082184
Issue number: closes #3723
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.