-
Notifications
You must be signed in to change notification settings - Fork 154
fix(parser): Update S3 Event Schema #3671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): Update S3 Event Schema #3671
Conversation
The sourceIPAddress field can be either an IP address or a fixed string ("s3.amazonaws.com").
The sequencer field is only present in PUT and DELETE events.
This comment was marked as outdated.
This comment was marked as outdated.
Added a test 🙈 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
PS: ignore the missing issue notice, right now it's using a regex that expects the issue number to be on the same line as the Issue Number:
text, but we're working on replacing it with a better system.
Summary
Update S3 Event Schema
Changes
s3.amazonaws.com
insourceIPAddress
fieldsequencer
field optional.Issue number: closes #3643
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.