Skip to content

fix(parser): Update S3 Event Schema #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

ConnorKirk
Copy link
Contributor

@ConnorKirk ConnorKirk commented Feb 27, 2025

Summary

Update S3 Event Schema

Changes

  • Allow literal s3.amazonaws.com in sourceIPAddress field
  • Make sequencer field optional.

Issue number: closes #3643


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

The sourceIPAddress field can be either an IP address or a fixed string ("s3.amazonaws.com").
The sequencer field is only present in PUT and DELETE events.
@ConnorKirk ConnorKirk requested review from a team as code owners February 27, 2025 11:28
@boring-cyborg boring-cyborg bot added the parser This item relates to the Parser Utility label Feb 27, 2025
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Feb 27, 2025
@github-actions github-actions bot added bug Something isn't working labels Feb 27, 2025

This comment was marked as outdated.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Feb 27, 2025
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Feb 27, 2025
@pull-request-size pull-request-size bot added size/M PR between 30-99 LOC and removed size/XS PR between 0-9 LOC labels Feb 27, 2025
@ConnorKirk
Copy link
Contributor Author

ConnorKirk commented Feb 27, 2025

Added a test 🙈
Code Coverage was happy, but it felt wrong

@dreamorosi dreamorosi added size/XS PR between 0-9 LOC and removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further size/M PR between 30-99 LOC tests PRs that add or change tests labels Feb 27, 2025
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!


PS: ignore the missing issue notice, right now it's using a regex that expects the issue number to be on the same line as the Issue Number: text, but we're working on replacing it with a better system.

@dreamorosi dreamorosi merged commit c14c7b3 into aws-powertools:main Feb 27, 2025
49 of 52 checks passed
@ConnorKirk ConnorKirk deleted the 3643-update-schema branch February 27, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser This item relates to the Parser Utility size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect data types for sourceIPAddress and sequencer Fields in S3RecordSchema Model
2 participants