Skip to content

Maintenance: add NO-OP user agent #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Feb 24, 2025 · 2 comments · Fixed by #3651
Closed
1 of 2 tasks

Maintenance: add NO-OP user agent #3650

dreamorosi opened this issue Feb 24, 2025 · 2 comments · Fixed by #3651
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

The AWS SDK offers the possibility to appending a user agent to requests sourcing the value from a known env variable (AWS_SDK_UA_APP_ID). We should set the environment variable when one is not set to include our ua to requests.

Why is this needed?

So that we can append the Powertools user agent to AWS SDK clients more effectively.

Which area does this relate to?

Governance

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) triage This item has not been triaged by a maintainer, please wait labels Feb 24, 2025
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Feb 24, 2025
@dreamorosi dreamorosi self-assigned this Feb 24, 2025
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Feb 24, 2025
@dreamorosi dreamorosi mentioned this issue Feb 24, 2025
Merged
@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Feb 25, 2025
@dreamorosi dreamorosi moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Feb 25, 2025
@dreamorosi dreamorosi linked a pull request Feb 25, 2025 that will close this issue
chore(maintenance): set app sdk ua env variable when none is set #3651
Merged
@github-actions GitHub Actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions GitHub Actions
Copy link
Contributor

This is now released under v2.15.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Feb 25, 2025
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
1 participant
@dreamorosi