feat(logger): refresh sample rate calculation per invocation #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in logger context
…or for invocations
boring-cyborg
bot
added
documentation
github-actions
bot
added
the
feature
dreamorosi
reviewed
Feb 24, 2025
dreamorosi
reviewed
Feb 24, 2025
|
dreamorosi
approved these changes
Feb 24, 2025
am29d
deleted the
issue3278/Feature-request-Calculate-Log-Sampling-Per-Request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in logger context## Summary
Changes
This PR modifies the
sampleRatebehaviour for the logger and will now sample per invocation, instead of execution environment. When usinginjectLambdaContexteither as decorator or as middleware, we now automatically refresh sample rate.Issue number: closes #3278
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.