-
Notifications
You must be signed in to change notification settings - Fork 153
feat(logger): Emit a warning on buffer flush #3639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dreamorosi
merged 3 commits into
aws-powertools:main
from
ConnorKirk:3625-log-warning-on-buffer-overflow
Feb 20, 2025
Merged
feat(logger): Emit a warning on buffer flush #3639
dreamorosi
merged 3 commits into
aws-powertools:main
from
ConnorKirk:3625-log-warning-on-buffer-overflow
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a warning to the flushBuffer method when the buffer being flushed has had logs evicted.
ConnorKirk
commented
Feb 20, 2025
ConnorKirk
commented
Feb 20, 2025
ConnorKirk
commented
Feb 20, 2025
|
dreamorosi
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
Feel free to go on the issue list and leave a comment under the next one, so I can assign it to you.
Well done!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a warning to the
flushBuffer
method when the buffer being flushed has had logs evicted.Changes
evictionCount
to theSizedSet
class. It is incremented when a log is evicted from the set.flushBuffer
method to emit a warning if there any logs have been evicted from the buffer being flushedThings to note:
SizedSet
class, but another Map on theCircularMap
mappingtraceId
to eviction status could also work.Issue number: #3625
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.