Skip to content

Maintenance: deprecate AlbMultiValueHeadersSchema in favor of AlbSchema for Parser #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Jan 24, 2025 · 2 comments · Fixed by #3523
Closed
1 of 2 tasks
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility

Comments

@dreamorosi
Copy link
Contributor

Summary

The AlbSchema & AlbMultiValueHeadersSchema are basically the same except for the latter extending the first by adding two properties. These two properties are mutually exclusive with the single-value version of headers and queryStringParameters and their presence depends on how the ALB is configured.

Because of this, we can deprecate the AlbMultiValueHeadersSchema, move the two properties within the AlbSchema and mark all four as .optional().

Why is this needed?

So that we can reduce the amount of built-in schemas customers have to choose from.

Which area does this relate to?

Parser

Solution

Mark the AlbMultiValueHeadersSchema as deprecated and move the two extended properties in the base AlbSchema.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility labels Jan 24, 2025
@dreamorosi dreamorosi self-assigned this Jan 24, 2025
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Jan 24, 2025
@dreamorosi dreamorosi moved this from Working on it to Pending review in Powertools for AWS Lambda (TypeScript) Jan 24, 2025
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Jan 24, 2025
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jan 24, 2025
Copy link
Contributor

This is now released under v2.13.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jan 28, 2025
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility
Projects
Development

Successfully merging a pull request may close this issue.

1 participant