fix(parser): EventBridge envelope uses correct path #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
parser
pull-request-size
bot
added
the
size/XXL
|
am29d
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR fixes the issue described in the linked issue by making it so that the
EventBridgeEnvelopethrows an error that includes the correct path to the issue. This will allow customers to more quickly identify the validation/parsing issue.To implement the change, and since we are not doing any special transform or handling of the payload in the
detailfield, I also refactored the envelope implementation so that the schema provided by the customer to validate the payload is used to extend the baseEventBridgeSchemaevent. This simplifies the implementation and lets Zod do the heavy lifting.While working on this PR I also removed some unused test events that were leftover from previous refactors.
Issue number: #3503
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.