Skip to content

Maintenance: remove aws-sdk/util-dynamodb dependency in favour of commons package #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
am29d opened this issue Jan 20, 2025 · 4 comments · Fixed by #3493
Closed
1 of 2 tasks

Maintenance: remove aws-sdk/util-dynamodb dependency in favour of commons package #3492

am29d opened this issue Jan 20, 2025 · 4 comments · Fixed by #3493
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility

Comments

@am29d
Copy link
Contributor

am29d commented Jan 20, 2025

Summary

In #3442 we missed to add @aws-sdk/util-dynamodb package to peerDependenciesMeta as option, which now pulls the dependency for some package managers like pnpm.

Remove util-dynamodb dependency since we have implemented the unmarshall function in our commons package.

Why is this needed?

Because we have moved the implementation of unmarshall function to commons package.

Which area does this relate to?

Parser

Solution

Add commons dependency to parser utility.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@am29d am29d added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) triage This item has not been triaged by a maintainer, please wait labels Jan 20, 2025
@am29d am29d added parser This item relates to the Parser Utility confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Jan 20, 2025
@am29d am29d self-assigned this Jan 20, 2025
@am29d am29d moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Jan 20, 2025
@dreamorosi
Copy link
Contributor

I think we should add the custom function we added in #3482 and remove the dependency altogether instead.

The function is present in the commons package and is already being used by the DynamoDB schema.

@am29d am29d changed the title Maintenance: add aws-sdk/util-dynamodb to peerDependenciesMeta as optional Maintenance: remove aws-sdk/util-dynamodb dependency in favour of commons package Jan 20, 2025
@am29d
Copy link
Contributor Author

am29d commented Jan 20, 2025

I agree, will adjust the title and description, as well the PR.

@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Jan 20, 2025
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jan 20, 2025
Copy link
Contributor

This is now released under v2.13.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jan 28, 2025
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility
Projects
2 participants