Skip to content

fix(parser): identitySource can be null in APIGatewayRequestAuthorizerEventV2Schema #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jan 17, 2025

Summary

This PR allows to parse identitySource with null value in APIGatewayRequestAuthorizerEventV2Schema.

Changes

Please provide a summary of what's being changed

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3483


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team January 17, 2025 10:43
@am29d am29d requested a review from a team as a code owner January 17, 2025 10:43
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Jan 17, 2025
@boring-cyborg boring-cyborg bot added parser This item relates to the Parser Utility tests PRs that add or change tests labels Jan 17, 2025
@am29d am29d changed the title fix(parser): identitySource to allow null values in parser fix(parser): identitySource can be null in APIGatewayRequestAuthorizerEventV2Schema Jan 17, 2025
@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2025

This comment was marked as outdated.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jan 17, 2025
@am29d am29d self-assigned this Jan 17, 2025
@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jan 17, 2025
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can avoid adding a test by modifying an existing one. Other than that, ready to merge.

@dreamorosi dreamorosi self-requested a review January 17, 2025 13:16
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@dreamorosi dreamorosi merged commit 8692de6 into main Jan 17, 2025
94 checks passed
@dreamorosi dreamorosi deleted the issue3483/bug-identitySource-null-in-apigwv2auth-request branch January 17, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser This item relates to the Parser Utility size/S PR between 10-29 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: APIGatewayRequestAuthorizerEventV2Schema has invalid definition for the identitySource field
2 participants