Skip to content

Feature request: remove usage of isDate in Metrics utility internals #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Jan 8, 2025 · 2 comments · Fixed by #3462
Closed
1 of 2 tasks

Feature request: remove usage of isDate in Metrics utility internals #3461

dreamorosi opened this issue Jan 8, 2025 · 2 comments · Fixed by #3462
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility metrics This item relates to the Metrics Utility

Comments

@dreamorosi
Copy link
Contributor

Use case

To improve compatibility with LLRT, we could replace the internal usage of the isDate method to a simpler instanceof Date check.

While we still maintain our stance of best effort support for LLRT, this change is an extremely low hanging fruit.

Solution/User Experience

The change should be totally transparent for customers and not require any change on their part.

Alternative solutions

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation feature-request This item refers to a feature request for an existing or new utility metrics This item relates to the Metrics Utility labels Jan 8, 2025
@dreamorosi dreamorosi self-assigned this Jan 8, 2025
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Jan 8, 2025
@dreamorosi dreamorosi linked a pull request Jan 8, 2025 that will close this issue
@dreamorosi dreamorosi moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jan 8, 2025
Copy link
Contributor

This is now released under v2.13.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jan 14, 2025
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility metrics This item relates to the Metrics Utility
Projects
Development

Successfully merging a pull request may close this issue.

1 participant