Skip to content

fix(parser): make SNS subject field nullish #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 13, 2024
Merged

fix(parser): make SNS subject field nullish #3415

merged 5 commits into from
Dec 13, 2024

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Dec 12, 2024 •
edited
Loading

Summary

Changes

Please provide a summary of what's being changed

This PR updates the Subject field for the SNS schema in the Parser utility to account for the field potentially being null. Before this change the field could only be a string or undefined, but when not provided by the sender, the field can instead be null.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3400

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Dec 12, 2024
@dreamorosi dreamorosi requested a review from a team December 12, 2024 19:02
@dreamorosi dreamorosi requested a review from a team as a code owner December 12, 2024 19:02
@dreamorosi dreamorosi linked an issue Dec 12, 2024 that may be closed by this pull request
Bug: SnsSchema parsing fails when Subject is null #3400
Closed
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Dec 12, 2024
@boring-cyborg boring-cyborg bot added the parser This item relates to the Parser Utility label Dec 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 12, 2024
@dreamorosi dreamorosi requested a review from sthulb December 12, 2024 19:03
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Dec 12, 2024
@dreamorosi dreamorosi changed the title fix(parser): make subject nullable fix(parser): make subject nullish Dec 12, 2024
@dreamorosi dreamorosi changed the title fix(parser): make subject nullish fix(parser): make SNS subject field nullish Dec 12, 2024
@dreamorosi dreamorosi requested a review from am29d December 12, 2024 19:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dreamorosi dreamorosi merged commit 0da9cea into main Dec 13, 2024
38 checks passed
@dreamorosi dreamorosi deleted the 3400-bug-snsschema-subject-nullish branch December 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am29d am29d am29d approved these changes

@sthulb sthulb Awaiting requested review from sthulb

@leandrodamascena leandrodamascena Awaiting requested review from leandrodamascena

Assignees

@dreamorosi dreamorosi

Labels
bug Something isn't working parser This item relates to the Parser Utility size/XS PR between 0-9 LOC tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: SnsSchema parsing fails when Subject is null
2 participants
@dreamorosi @am29d