fix(metrics): skip empty string dimension values #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
metrics
arnabrahman
changed the title
addDimension & addDimensionsaddDimension & addDimensions
dreamorosi
changed the title
addDimension & addDimensionsaddDimension & addDimensions
dreamorosi
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Thank you for the revisions @arnabrahman!
The friends at the Python version told me they already merged the change and used a slightly different wording in the warning log, which you can see here and is this:
The dimension {name} doesn't meet the requirements and won't be added. Ensure the dimension name and value are non empty strings"
As last step before merging, could you please change to this?
I'll merge right after, sorry I missed the change on their part and didn't point it out in my first review of your PR.
|
|
It's ok, i have updated the warning message. |
dreamorosi
approved these changes
Nov 19, 2024
dreamorosi
changed the title
addDimension & addDimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When adding a dimension to my metrics, I should get a warning if the dimension value is invalid aka an empty string ("") or undefined/null, and the dimension should not be added to the EMF blobs emitted by the utility.
Changes
empty,undefined&nullvalues for dimension and if found log warningaddDimension&addDimensionsIssue number: #3302
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.