Skip to content

Maintenance: revert changes to relative imports in Parser #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Nov 4, 2024 · 2 comments · Fixed by #3287
Closed
1 of 2 tasks

Maintenance: revert changes to relative imports in Parser #3286

dreamorosi opened this issue Nov 4, 2024 · 2 comments · Fixed by #3287
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility

Comments

@dreamorosi
Copy link
Contributor

Summary

In #3250 we introduced a regression in the Parser package by modifying some relative imports to exclude the file extension. This caused errors during the build of the package:
Image

Why is this needed?

So that builds of the package are executed without errors/warnings and the resulting package is correct.

Which area does this relate to?

Parser

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility labels Nov 4, 2024
@dreamorosi dreamorosi self-assigned this Nov 4, 2024
@dreamorosi dreamorosi moved this from Triage to Pending review in Powertools for AWS Lambda (TypeScript) Nov 4, 2024
@dreamorosi dreamorosi added the confirmed The scope is clear, ready for implementation label Nov 4, 2024
@dreamorosi dreamorosi mentioned this issue Nov 4, 2024
Merged
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Nov 5, 2024
@dreamorosi dreamorosi mentioned this issue Nov 11, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

This is now released under v2.11.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Nov 20, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix relative import regression aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi