Skip to content

Maintenance: temporarily remove Zod schema parsing from layer canary #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Oct 8, 2024 · 2 comments · Fixed by #3171
Closed
1 of 2 tasks

Maintenance: temporarily remove Zod schema parsing from layer canary #3170

dreamorosi opened this issue Oct 8, 2024 · 2 comments · Fixed by #3171
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline

Comments

@dreamorosi
Copy link
Contributor

Summary

In a recent PR (#3101) we introduced Parser to the Lambda layer we publish for Powertools for AWS Lambda. As part of this effort we added a test that parses the event of the Lambda function using a specific schema (Event Bridge event).

This works for e2e tests since we control the payload sent to the function being tested but doesn't work with the current setup we have for canary tests, which implicitly invoke the function by using a CDK custom resource with provider model.

Why is this needed?

So that we can move forward with the release.

Besides, the current test setup is not really testing the Parser utility as much as it's testing Zod itself, which is besides the point of the test.

Which area does this relate to?

Other

Solution

Temporarily remove the parsing of the event from the test and add it back again once we have refactored the code.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline labels Oct 8, 2024
@dreamorosi dreamorosi self-assigned this Oct 8, 2024
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Oct 8, 2024
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This is now released under v2.9.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Oct 8, 2024
@dreamorosi dreamorosi moved this from Coming soon to Closed in Powertools for AWS Lambda (TypeScript) Oct 9, 2024
@dreamorosi dreamorosi moved this from Closed to Shipped in Powertools for AWS Lambda (TypeScript) Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline
Projects
Development

Successfully merging a pull request may close this issue.

1 participant