You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dreamorosi opened this issue
Oct 8, 2024
· 2 comments
· Fixed by #3171
Assignees
Labels
completedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)layersItems related to the Lambda Layers pipeline
In a recent PR (#3101) we introduced Parser to the Lambda layer we publish for Powertools for AWS Lambda. As part of this effort we added a test that parses the event of the Lambda function using a specific schema (Event Bridge event).
This works for e2e tests since we control the payload sent to the function being tested but doesn't work with the current setup we have for canary tests, which implicitly invoke the function by using a CDK custom resource with provider model.
Why is this needed?
So that we can move forward with the release.
Besides, the current test setup is not really testing the Parser utility as much as it's testing Zod itself, which is besides the point of the test.
Which area does this relate to?
Other
Solution
Temporarily remove the parsing of the event from the test and add it back again once we have refactored the code.
Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered:
dreamorosi
added
confirmed
The scope is clear, ready for implementation
internal
PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
layers
Items related to the Lambda Layers pipeline
labels
Oct 8, 2024
completedThis item is complete and has been merged/shippedinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)layersItems related to the Lambda Layers pipeline
Summary
In a recent PR (#3101) we introduced Parser to the Lambda layer we publish for Powertools for AWS Lambda. As part of this effort we added a test that parses the event of the Lambda function using a specific schema (Event Bridge event).
This works for e2e tests since we control the payload sent to the function being tested but doesn't work with the current setup we have for canary tests, which implicitly invoke the function by using a CDK custom resource with provider model.
Why is this needed?
So that we can move forward with the release.
Besides, the current test setup is not really testing the Parser utility as much as it's testing Zod itself, which is besides the point of the test.
Which area does this relate to?
Other
Solution
Temporarily remove the parsing of the event from the test and add it back again once we have refactored the code.
Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: