Skip to content

Maintenance: improve type hints when using log reordering feature #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Sep 12, 2024 · 2 comments · Fixed by #3054
Closed
1 of 2 tasks

Maintenance: improve type hints when using log reordering feature #3053

dreamorosi opened this issue Sep 12, 2024 · 2 comments · Fixed by #3054
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) logger This item relates to the Logger Utility

Comments

@dreamorosi
Copy link
Contributor

Summary

In #2736 we added a feature that allows customers to specify an order for how the keys will appear in each log. This feature represents a middle ground between wanting to customize the Logger without having to create and maintain your own custom log formatter.

While the feature is great, customers using this feature might not be familiar with all the keys that Logger can include in its log. We should improve our types around the feature so that customers get some type hints and useful autocomplete when specifying the log order.

Why is this needed?

So that customers can be aware of the available keys that they can specify when using the feature without having to open the browser and check the documentation.

Which area does this relate to?

Logger

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added logger This item relates to the Logger Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Sep 12, 2024
@dreamorosi dreamorosi self-assigned this Sep 12, 2024
@dreamorosi dreamorosi moved this from Triage to Pending review in Powertools for AWS Lambda (TypeScript) Sep 12, 2024
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Sep 13, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Sep 13, 2024
Copy link
Contributor

This is now released under v2.8.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Sep 16, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) logger This item relates to the Logger Utility
Projects
Development

Successfully merging a pull request may close this issue.

1 participant