Skip to content

Maintenance: fix idempotency e2e tests #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Jun 7, 2024 · 2 comments · Fixed by #2622
Closed
1 of 2 tasks

Maintenance: fix idempotency e2e tests #2621

dreamorosi opened this issue Jun 7, 2024 · 2 comments · Fixed by #2622
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Summary

After merging #2570 some of the integration tests related to the Idempotency utility are failing.

This is because some of the payloads used to seed the tests don't match the control idempotency key due to the former not being deep sorted.

This was raised during the review but I forgot to ask the contributor to include it before merging.

Why is this needed?

So that we can continue running integration tests.

Which area does this relate to?

Tests

Solution

We should make sure that all the payloads in the packages/idempotency/tests/e2e/makeIdempotent.test.ts file are sorted.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) idempotency This item relates to the Idempotency Utility confirmed The scope is clear, ready for implementation tests PRs that add or change tests labels Jun 7, 2024
@dreamorosi dreamorosi self-assigned this Jun 7, 2024
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Jun 7, 2024
@dreamorosi dreamorosi mentioned this issue Jun 7, 2024
Merged
@dreamorosi dreamorosi moved this from Working on it to Pending review in Powertools for AWS Lambda (TypeScript) Jun 7, 2024
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This is now released under v2.2.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jun 13, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(idempotency): fix integration tests aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi