Skip to content

Docs: update-layer-arn should also update CDK example #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
am29d opened this issue May 7, 2024 · 1 comment · Fixed by #2487
Closed
1 task done

Docs: update-layer-arn should also update CDK example #2486

am29d opened this issue May 7, 2024 · 1 comment · Fixed by #2487
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation

Comments

@am29d
Copy link
Contributor

am29d commented May 7, 2024

What were you searching in the docs?

Our update_layer_arn.sh should update the layer version in our docs after a new layer deployment. But it turns out the CDK example using the layer is not updated any more.

Is this related to an existing documentation section?

No response

How can we improve?

We need to add ${Stack.of(this).region} to the select check to replace the version number. The current implementation has ${cdk.Stack.of(this).region} where cdk prefix is the causing problem.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@am29d am29d added documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait labels May 7, 2024
@am29d am29d self-assigned this May 7, 2024
@am29d am29d added confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels May 7, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) May 7, 2024
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
Development

Successfully merging a pull request may close this issue.

2 participants