Skip to content

Maintenance: make ParsingOption name clearer in JMESPath utility #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Apr 16, 2024 · 2 comments · Fixed by #2367
Closed
1 of 2 tasks

Maintenance: make ParsingOption name clearer in JMESPath utility #2369

dreamorosi opened this issue Apr 16, 2024 · 2 comments · Fixed by #2367
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) jmespath This item relates to the JMESPath Utility

Comments

@dreamorosi
Copy link
Contributor

Summary

Customer using the JMESPath utility can customize the way expressions are parsed by specifying options, for example they can extend the functions available.

Currently the option and corresponding type for this feature is called ParsingOption which is overly generic.

We should rename it to clarify what it does and where it comes from.

Why is this needed?

Because the utility is being consumed by other packages like Idempotency and because there's another upcoming utility called Parser.

Namespacing the type by using something like JMESPathParsingOptions would immediately make it clear where the option comes from and what it's for.

Which area does this relate to?

JMESPath

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation jmespath This item relates to the JMESPath Utility labels Apr 16, 2024
@dreamorosi dreamorosi self-assigned this Apr 16, 2024
@dreamorosi dreamorosi moved this from Triage to Pending review in Powertools for AWS Lambda (TypeScript) Apr 16, 2024
@dreamorosi dreamorosi linked a pull request Apr 16, 2024 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Apr 16, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Apr 16, 2024
Copy link
Contributor

This is now released under v2.1.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Apr 18, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) jmespath This item relates to the JMESPath Utility
Projects
Development

Successfully merging a pull request may close this issue.

1 participant