-
Notifications
You must be signed in to change notification settings - Fork 154
Maintenance: align timestamp formats for expiration
and in_progress_expiration
in idempotency table
#2298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
expiration
and in_progress_expiration
expiration
and in_progress_expiration
in idempotency table
Hi @RaphaelManke thanks for opening this issue. I need to triage this to know for sure, but I would assume that the two formats are different because one ( Both timestamps are used in DynamoDB write conditions and compared against a unix timestamps generate using I think we should probably make the two format consistent, however I'm trying to determine whether this is a bug or just a consistency issue. Besides consistency and the inaccurate docs, have you encountered any bug related to this? |
No I didn't encountered a bug, but there was no other issue type matching 😃 |
It's alright, it wasn't about the issue type - I just wanted to make sure this wasn't causing runtime bugs. I'm going to label this as As part of this task we should update the logic of this function so that the return value is rounded to an integer number. |
expiration
and in_progress_expiration
in idempotency tableexpiration
and in_progress_expiration
in idempotency table
You can assign me @dreamorosi |
This issue is now closed. Please be mindful that future comments are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so. |
Expected Behaviour
I'd expect that the values
expiration
andin_progress_expiration
are using the same timestamp formatCurrent Behaviour
expiration
uses float numbersin_progress_expiration
uses integerCode snippet
See docs examples.
Steps to Reproduce
Possible Solution
No response
Powertools for AWS Lambda (TypeScript) version
latest
AWS Lambda function runtime
20.x
Packaging format used
npm
Execution logs
No response
The text was updated successfully, but these errors were encountered: