Skip to content

docs: fix link in announcement banner #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Feb 19, 2024 Discussed in #2085 · 1 comment · Fixed by #2091
Closed

docs: fix link in announcement banner #2090

dreamorosi opened this issue Feb 19, 2024 Discussed in #2085 · 1 comment · Fixed by #2091
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation

Comments

@dreamorosi
Copy link
Contributor

As discussed in #2085, the link to the upgrade guide in the announcement banner is broken (it's missing a /latest).

Screenshot 2024-02-19 at 14 55 04

The other link in the menu bar is working, but we should fix it right away.


Originally posted by ilmarivacklinsc February 19, 2024
Right now the link goes to: https://docs.powertools.aws.dev/lambda/typescript/upgrade

When I click on it, I get this:

<Error>
<Code>NoSuchKey</Code>
<Message>The specified key does not exist.</Message>
<Key>index.html</Key>
<RequestId>P7YYZF0ZDDXTNEM9</RequestId>
<HostId>
D8HRWdnkaLV/8edXVYKt2jmQFaYL8KP9vghINwxAazuSe7r/KYqKnOMga6035S9MNcViZ2VHqfo=
</HostId>
</Error>

I feel there could be a better UX for this if the upgrade guide isn't available yet.

@dreamorosi dreamorosi self-assigned this Feb 19, 2024
@dreamorosi dreamorosi added documentation Improvements or additions to documentation confirmed The scope is clear, ready for implementation labels Feb 19, 2024
@dreamorosi dreamorosi moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Feb 19, 2024
@dreamorosi dreamorosi linked a pull request Feb 19, 2024 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Feb 19, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Feb 19, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Feb 20, 2024
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
Development

Successfully merging a pull request may close this issue.

1 participant