Skip to content

Maintenance: restore changelog creation #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Jan 27, 2024 · 3 comments · Fixed by #2101
Closed
1 of 2 tasks

Maintenance: restore changelog creation #1982

dreamorosi opened this issue Jan 27, 2024 · 3 comments · Fixed by #2101
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

For each release, together with the release notes, we also publish the changes for each package in their respective changeling file (i.e. packages/logger/CHANGELOG.md).

For the last two releases the changelog files didn't get updated.

Why is this needed?

So that customers can have a breakdown of all the changes in a file related to the package.

However the fact that nobody reported this might suggest not many people are actually looking at these files. The same info, plus additional explanations are already available in the release notes.

Which area does this relate to?

No response

Solution

We need to investigate further, but the releases stopped being generated after we dropped support for Node.js 14 which is also when we upgraded to lerna v7.0.x. The release notes don't have anything related to this, so it's not clear why it stopped adding updates to the files.

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) discussing The issue needs to be discussed, elaborated, or refined labels Jan 27, 2024
@dreamorosi dreamorosi moved this from Triage to Backlog in Powertools for AWS Lambda (TypeScript) Jan 27, 2024
@am29d am29d self-assigned this Feb 12, 2024
@dreamorosi dreamorosi assigned dreamorosi and unassigned am29d Feb 20, 2024
@dreamorosi dreamorosi moved this from Backlog to Working on it in Powertools for AWS Lambda (TypeScript) Feb 20, 2024
@dreamorosi
Copy link
Contributor Author

As evidenced by #2100 the changelog creation is working again, so there's no fix to apply.

I'll open a PR to manually write the change log for the 2-3 missing releases.

@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed discussing The issue needs to be discussed, elaborated, or refined labels Feb 20, 2024
@dreamorosi dreamorosi moved this from Working on it to Pending review in Powertools for AWS Lambda (TypeScript) Feb 20, 2024
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Feb 20, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Feb 20, 2024
Copy link
Contributor

This is now released under v1.18.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Feb 20, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
2 participants