Skip to content

Maintenance: performance tests for parser #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
am29d opened this issue Jan 25, 2024 · 2 comments
Closed
1 of 2 tasks

Maintenance: performance tests for parser #1955

am29d opened this issue Jan 25, 2024 · 2 comments
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility rejected This is something we will not be working on. At least, not in the measurable future

Comments

@am29d
Copy link
Contributor

am29d commented Jan 25, 2024

Summary

There are many different validation libraries available and we decided to use zod because of the combination of popularity, adoption, open source health and security. This is ideal for customer who already have zod schemas and want to use them in their workloads. For customers who want to start using runtime validation, the questions is which library they should use.

There are different benchmarks on validation libraries performance, but we don't have numbers how they perform in Lambda runtime. It is clear that they will not be faster. But for most customer looking into parser and zod specifically, customers will ask the question how the performance overhead is when using parser.

We should run performance tests for parser validation using zod and compare it to runtime without the parser. The possible variables are: nodejs version, memory, built-in schema, custom schema.

Why is this needed?

We need to understand the performance impact of parser utility and documental it transparently so customer can decide if they can use this utility, without experience negative impact after the implementation.

Which area does this relate to?

Parser

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@am29d am29d added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Jan 25, 2024
@am29d am29d added this to the Parser - Beta Release milestone Jan 25, 2024
@am29d am29d added confirmed The scope is clear, ready for implementation parser This item relates to the Parser Utility and removed triage This item has not been triaged by a maintainer, please wait labels Jan 25, 2024
@am29d am29d changed the title Maintenance: performance tests Maintenance: performance tests for parser Jan 25, 2024
@dreamorosi dreamorosi moved this from Triage to Backlog in Powertools for AWS Lambda (TypeScript) Jan 25, 2024
@am29d am29d self-assigned this Jan 25, 2024
@am29d am29d added the on-hold This item is on-hold and will be revisited in the future label Apr 8, 2024
@dreamorosi dreamorosi moved this from Backlog to Ideas in Powertools for AWS Lambda (TypeScript) Apr 15, 2024
@dreamorosi dreamorosi removed the confirmed The scope is clear, ready for implementation label Apr 15, 2024
@dreamorosi dreamorosi removed this from the Parser - Beta Release milestone Apr 15, 2024
@dreamorosi dreamorosi added discussing The issue needs to be discussed, elaborated, or refined and removed on-hold This item is on-hold and will be revisited in the future labels Apr 18, 2024
@dreamorosi dreamorosi moved this from Ideas to Backlog in Powertools for AWS Lambda (TypeScript) Apr 18, 2024
@dreamorosi
Copy link
Contributor

I'll close this issue for now, and in the coming months we'll open a more general issue related to performance testing as described in the roadmap.

@dreamorosi dreamorosi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (TypeScript) Feb 14, 2025
@dreamorosi dreamorosi moved this from Coming soon to Closed in Powertools for AWS Lambda (TypeScript) Feb 14, 2025
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added rejected This is something we will not be working on. At least, not in the measurable future and removed discussing The issue needs to be discussed, elaborated, or refined labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) parser This item relates to the Parser Utility rejected This is something we will not be working on. At least, not in the measurable future
Projects
Development

No branches or pull requests

2 participants