Skip to content

Maintenance: adopt AWS CDK cli library #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Jul 24, 2023 · 2 comments · Fixed by #1633
Closed
1 of 2 tasks

Maintenance: adopt AWS CDK cli library #1623

dreamorosi opened this issue Jul 24, 2023 · 2 comments · Fixed by #1633
Assignees
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests

Comments

@dreamorosi
Copy link
Contributor

Summary

To run our integration (e2e) tests we deploy resources to an AWS account via CDK. These resources are spun up right before the test and then destroyed immediately afterwards. When we first wrote this infrastructure, CDK didn't allow programmatic use and so we had to rely on some workarounds. In the past months however CDK has released a new alpha module called @aws-cdk/cli-lib-alpha (link) that could potentially replace our workarounds.

We should look into this module and create an utility that can be used in all the tests that require AWS resources.

Why is this needed?

The current implementation relies on an internal CDK API. As such, its implementation can change at any time and break our test infrastructure. This has happened in one of the latest releases of CDK.

Which area does this relate to?

Tests

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation tests PRs that add or change tests labels Jul 24, 2023
@dreamorosi dreamorosi self-assigned this Jul 24, 2023
@dreamorosi dreamorosi linked a pull request Jul 24, 2023 that will close this issue
9 tasks
@dreamorosi dreamorosi removed a link to a pull request Jul 27, 2023
9 tasks
@dreamorosi dreamorosi linked a pull request Jul 27, 2023 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Jul 28, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jul 28, 2023
@github-actions
Copy link
Contributor

This is now released under v1.13.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Sep 18, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests
Projects
Development

Successfully merging a pull request may close this issue.

1 participant