Skip to content

Feature request: implement makeBatchHandler Middy middleware #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Jul 13, 2023 · 3 comments
Closed

Feature request: implement makeBatchHandler Middy middleware #1608

dreamorosi opened this issue Jul 13, 2023 · 3 comments
Labels
batch This item relates to the Batch Processing Utility feature-request This item refers to a feature request for an existing or new utility rejected This is something we will not be working on. At least, not in the measurable future

Comments

@dreamorosi
Copy link
Contributor

Use Case

Customers who use Middy middlewares might want to use the Batch Processing utility as a Middy middleware.

Solution/User Experience

Refer to example shown in the RFC #1082, section 3.2

Acceptance criteria

  • The class covers all the features found in the reference implementation
  • The middleware is exported
  • Unit tests are implemented with 100% coverage.
  • All functions are documented via docstrings, following project's conventions as much as possible
@dreamorosi dreamorosi converted this from a draft issue Jul 13, 2023
@dreamorosi dreamorosi added feature-request This item refers to a feature request for an existing or new utility confirmed The scope is clear, ready for implementation batch This item relates to the Batch Processing Utility labels Jul 13, 2023
@dreamorosi dreamorosi assigned dreamorosi and unassigned dreamorosi Jul 15, 2023
@dreamorosi dreamorosi moved this from Backlog to Ideas in Powertools for AWS Lambda (TypeScript) Jul 20, 2023
@dreamorosi dreamorosi added discussing The issue needs to be discussed, elaborated, or refined and removed confirmed The scope is clear, ready for implementation labels Jul 20, 2023
@dreamorosi dreamorosi added the need-customer-feedback Requires more customers feedback before making or revisiting a decision label Jul 20, 2023
@dreamorosi
Copy link
Contributor Author

With the current implementation of the Batch Processing utility, processing a batch of records sent to a Lambda handler requires one line (excluding formatting):

export const handler = async (
  event: SQSEvent,
  context: Context
): Promise<SQSBatchResponse> => {
  return await asyncProcessPartialResponse(event, recordHandler, processor, {
    context,
  });
};

At the moment we are unsure about the value added by a Middy middleware besides syntactic sugar for those users who like using middlewares as a pattern.

For this reason we are excluding this feature from the base version of the utility and will leave the issue open so that customers can express their interest. If there's enough demand we will implement the middleware before the utility reaches General Availability.

@dreamorosi dreamorosi removed this from the Batch Processing - GA Release milestone Sep 13, 2023
@dreamorosi dreamorosi added rejected This is something we will not be working on. At least, not in the measurable future and removed need-customer-feedback Requires more customers feedback before making or revisiting a decision discussing The issue needs to be discussed, elaborated, or refined labels Feb 21, 2024
@dreamorosi
Copy link
Contributor Author

Due to the lack of traction on this issue in the last 6+ months, I'm gonna go ahead and close it.

If you are interested in this feature, please open a new feature request describing your use case and we'll be happy to reconsider.

@dreamorosi dreamorosi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@dreamorosi dreamorosi moved this from Coming soon to Closed in Powertools for AWS Lambda (TypeScript) Feb 21, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch This item relates to the Batch Processing Utility feature-request This item refers to a feature request for an existing or new utility rejected This is something we will not be working on. At least, not in the measurable future
Projects
Development

No branches or pull requests

1 participant