Skip to content

Feature request: allow to access processed messages #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Jul 11, 2023 · 3 comments · Fixed by #1588
Closed

Feature request: allow to access processed messages #1604

dreamorosi opened this issue Jul 11, 2023 · 3 comments · Fixed by #1588
Assignees
Labels
batch This item relates to the Batch Processing Utility completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility

Comments

@dreamorosi
Copy link
Contributor

Use Case

In the Python version of Powertools for AWS customers using the Batch Processing utility are able to access an array of the processed batch to apply further processing. This is useful for those customers who might want to apply some special handling to successes/failures like creating custom metrics, or notifying an out-of-bounds downstream service.

Solution/User Experience

Refer to RFC #1082, section 4.2

Acceptance criteria

  • The implementation allows the same degree of access/customization that the reference implementation has, while staying idiomatic with Node.js
  • Return and input types of each method are appropriate
  • Unit tests are implemented with 100% coverage
  • Any new method is documented via docstrings, following project's conventions as much as possible
@dreamorosi dreamorosi converted this from a draft issue Jul 11, 2023
@dreamorosi dreamorosi added feature-request This item refers to a feature request for an existing or new utility confirmed The scope is clear, ready for implementation batch This item relates to the Batch Processing Utility labels Jul 11, 2023
@dreamorosi
Copy link
Contributor Author

With #1588 merged, the implementation introduced in the PR already allows you to access the processed messages.

This feature is used extensively in the unit tests to assert on the output of the process() method.

@erikayao93
Copy link
Contributor

Implementation was finished as stated

@dreamorosi dreamorosi linked a pull request Jul 11, 2023 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (TypeScript) Jul 11, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jul 11, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Jul 11, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch This item relates to the Batch Processing Utility completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility
Projects
2 participants