Skip to content

Maintenance: Fixes in LogFormatter -- return type and variable naming #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
erikayao93 opened this issue Jul 5, 2023 · 1 comment · Fixed by #1585
Closed
1 of 2 tasks

Maintenance: Fixes in LogFormatter -- return type and variable naming #1584

erikayao93 opened this issue Jul 5, 2023 · 1 comment · Fixed by #1585
Assignees
@erikayao93
Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) logger This item relates to the Logger Utility

Comments

@erikayao93
Copy link
Contributor

Summary

Updating the formatAttributes docstring in PowertoolsLogFormatter to match the correct return type.
Renaming powertoolLogItem in formatAttributes method for naming consistency.

Why is this needed?

Correctness in code on the LogFormatter update

Which area does this relate to?

Logger

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@erikayao93 erikayao93 added triage This item has not been triaged by a maintainer, please wait internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Jul 5, 2023
@erikayao93 erikayao93 mentioned this issue Jul 5, 2023
Merged
9 tasks
@dreamorosi dreamorosi added logger This item relates to the Logger Utility confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Jul 5, 2023
@dreamorosi dreamorosi linked a pull request Jul 8, 2023 that will close this issue
fix(logger): PowertoolsLogFormatter docstring and variable naming update #1585
Merged
9 tasks
@dreamorosi dreamorosi moved this from Working on it to Shipped in Powertools for AWS Lambda (TypeScript) Jul 8, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Jul 8, 2023
@github-project-automation github-project-automation bot moved this from Shipped to Coming soon in Powertools for AWS Lambda (TypeScript) Jul 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikayao93 erikayao93

Labels
completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) logger This item relates to the Logger Utility
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
2 participants
@dreamorosi @erikayao93