Skip to content

Maintenance: write integration tests for makeHandlerIdempotent Middy middleware #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Jun 26, 2023 · 3 comments · Fixed by #1591
Closed
1 of 2 tasks

Maintenance: write integration tests for makeHandlerIdempotent Middy middleware #1555

dreamorosi opened this issue Jun 26, 2023 · 3 comments · Fixed by #1591
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Milestone
Idempotency - Bet...

Comments

@dreamorosi
Copy link
Contributor

Summary

The current test surface of the Idempotency utility doesn't include integration tests for the makeHandlerIdempotent Middy middleware. We should add tests for it before releasing the public beta.

Why is this needed?

To increase confidence on the middleware.

Which area does this relate to?

Idempotency

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Jun 26, 2023
@dreamorosi dreamorosi added this to the Idempotency - Beta release milestone Jun 26, 2023
@dreamorosi
Copy link
Contributor Author

Currently the tests only cover the makeFunctionIdempotent function wrapper, we can reuse most of the cases.

@dreamorosi dreamorosi self-assigned this Jul 5, 2023
@dreamorosi dreamorosi moved this from Backlog to Working on it in Powertools for AWS Lambda (TypeScript) Jul 5, 2023
@dreamorosi dreamorosi added the idempotency This item relates to the Idempotency Utility label Jul 5, 2023
@dreamorosi dreamorosi mentioned this issue Jul 8, 2023
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Jul 10, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jul 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited by dreamorosi
Loading

This is now released under v1.11.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jul 11, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
Idempotency - Beta release
Development

Successfully merging a pull request may close this issue.

test(idempotency): improve integration tests for utility aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi