Skip to content

Docs: contributing - setup instructions #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
dreamorosi opened this issue Jun 1, 2023 · 1 comment · Fixed by #1478
Closed
1 task done

Docs: contributing - setup instructions #1477

dreamorosi opened this issue Jun 1, 2023 · 1 comment · Fixed by #1478
Assignees
@dreamorosi
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation

Comments

@dreamorosi
Copy link
Contributor

What were you searching in the docs?

As reported on Discord (link), the Contributing guide present in the repo recommends users to install [email protected] in order to contribute to the project.

Since several months however the project has moved to Node.js 18.x, which comes with [email protected].

Is this related to an existing documentation section?

https://github.com/awslabs/aws-lambda-powertools-typescript/blob/main/CONTRIBUTING.md#setup

How can we improve?

The project uses Node.js 18 which already comes with a newer `npm` version (9.x), the guide should be updated to reflect this.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@dreamorosi dreamorosi added documentation Improvements or additions to documentation confirmed The scope is clear, ready for implementation labels Jun 1, 2023
@dreamorosi dreamorosi self-assigned this Jun 1, 2023
@dreamorosi dreamorosi mentioned this issue Jun 1, 2023
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Jun 1, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Jun 1, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(docs): fix setup steps in contributing doc aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi