-
Notifications
You must be signed in to change notification settings - Fork 154
Maintenance: fix version bump in examples #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Currently the examples are not part of the npm workspace but are part of the Basically the To solve/go around the issue I'm thinking of two options:
Between these two I'm leaning towards number 1. Making the examples folders part of the npm workspace would remove the need to bump the version numbers altogether given that the dependencies would be linked. This would also mean that whenever there's a change to the libraries the examples should be updated as well (assuming it's a breaking change). Finally, using this method would also slightly simplify the setup process of the repo requiring a single |
After starting to work on this, I think we'll need to do both methods described above after all. Including the packages in the workspace is needed as it consolidates the packages & configs and removes duplication, however we still need find a way to increase the version number in the examples (see example below) when a release happens. Currently both |
After additional investigation and after having moved both examples under the npm workspace, removing the current existing I'll push a PR soon. |
|
Summary
Every time we make a release we want the examples present in the repository under
examples/*
to use the latest version of the Powertools utilities. This allows to keep the examples in sync with the current feature set.Why is this needed?
We want to make sure that the examples that we offer are accurate and work with the latest release published on npm. Currently this requires a manual version bump after a release, which can be problematic.
Which area does this relate to?
Tests
Solution
TBD
Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: