You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
varqasim opened this issue
Jan 20, 2023
· 3 comments
Assignees
Labels
loggerThis item relates to the Logger Utilitynot-a-bugNew and existing bug reports incorrectly submitted as bugrejectedThis is something we will not be working on. At least, not in the measurable future
Using @middy/core v1.5.1 & just updated @aws-lambda-powertools/logger to v1.5.1 and I believe that adding the middy interface #1225 is causing a TS compilation error in my project. I was able to get rid of it by downgrading to v1.5.0.
The following compilation error I am presented with is
Argument of type 'MiddlewareLikeObj<unknown, unknown, Error, Context>' is not assignable to parameter of type 'MiddlewareObject<APIGatewayProxyEvent, { statusCode: number; body: string; }, Context> | MiddlewareObject<APIGatewayProxyEvent, { ...; }, Context>[]'.
Type 'MiddlewareLikeObj<unknown, unknown, Error, Context>' is not assignable to type 'MiddlewareObject<APIGatewayProxyEvent, { statusCode: number; body: string; }, Context>'.
Types of property 'before' are incompatible.
Type 'MiddlewareFn<unknown, unknown, Error, Context>' is not assignable to type 'MiddlewareFunction<APIGatewayProxyEvent, { statusCode: number; body: string; }, Context>'.
Types of parameters 'request' and 'handler' are incompatible.
Property 'internal' is missing in type 'HandlerLambda<APIGatewayProxyEvent, { statusCode: number; body: string; }, Context>' but required in type 'Request<unknown, unknown, Error, Context>'.ts(2345)
middy.d.ts(14, 5): 'internal' is declared here.
I came to this conclusion by looking at the last line middy.d.ts(14, 5): 'internal' is declared here. which was introduced in this PR introduced #1225.
If you still have issues also with that version, could you also share an example of how you're bundling your code and your configs, so that we can investigate further?
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.
dreamorosi
added
rejected
This is something we will not be working on. At least, not in the measurable future
logger
This item relates to the Logger Utility
and removed
triage
This item has not been triaged by a maintainer, please wait
labels
Jun 9, 2023
loggerThis item relates to the Logger Utilitynot-a-bugNew and existing bug reports incorrectly submitted as bugrejectedThis is something we will not be working on. At least, not in the measurable future
Expected Behaviour
The project would compile successfully
Current Behaviour
Using @middy/core v1.5.1 & just updated @aws-lambda-powertools/logger to v1.5.1 and I believe that adding the middy interface #1225 is causing a TS compilation error in my project. I was able to get rid of it by downgrading to v1.5.0.
The following compilation error I am presented with is
I came to this conclusion by looking at the last line
middy.d.ts(14, 5): 'internal' is declared here.
which was introduced in this PR introduced #1225.Code snippet
Possible Solution
No response
Steps to Reproduce
Install @middy/core v1.5.1 & and set @aws-lambda-powertools/logger to v1.5.1
AWS Lambda Powertools for TypeScript version
1.51
AWS Lambda function runtime
14.x
Packaging format used
Npm
Execution logs
No response
The text was updated successfully, but these errors were encountered: