Skip to content

Docs: Example of tracer.captureMethod() should demo in async instead of sync function #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
kennethwkz-mm opened this issue Dec 29, 2022 · 4 comments · Fixed by #1229
Closed
1 task done
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation

Comments

@kennethwkz-mm
Copy link

What were you searching in the docs?

About the tracer.captureMethod() example of correct usage, actually the method is not support non-promise function.

Is this related to an existing documentation section?

https://awslabs.github.io/aws-lambda-powertools-typescript/latest/core/tracer/#methods

How can we improve?

It should change the example with show @tracer.captureMethod() in async - promise function.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@kennethwkz-mm kennethwkz-mm added documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait labels Dec 29, 2022
@dreamorosi dreamorosi added good-first-issue Something that is suitable for those who want to start contributing help-wanted We would really appreciate some support from community for this one confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Dec 29, 2022
@dreamorosi
Copy link
Contributor

Thank you @kennethwkz-mm for spotting and reporting this. We do indeed need to make the change as it could be confusing for folks copy/pasting the example (as proven by our conversation on Discord).

I have added the help-wanted & good-first-issue labels. If anyone wants to pick this up, please leave a comment below to discuss and have the issue assigned to you before opening a PR. Apart from that, it should be a fairly straightforward change so I'll be happy to review & merge it once it's up.

@dreamorosi
Copy link
Contributor

As part of #1219 we are reworking some of the code snippets of that page, we will address this issue as part of that work.

@dreamorosi dreamorosi linked a pull request Jan 12, 2023 that will close this issue
13 tasks
@dreamorosi dreamorosi moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript Jan 12, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed good-first-issue Something that is suitable for those who want to start contributing help-wanted We would really appreciate some support from community for this one confirmed The scope is clear, ready for implementation labels Jan 12, 2023
@niko-achilles
Copy link
Contributor

this is addressed in PR #1229

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation
Projects
None yet
3 participants