-
Notifications
You must be signed in to change notification settings - Fork 154
Docs: Example of tracer.captureMethod() should demo in async instead of sync function #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you @kennethwkz-mm for spotting and reporting this. We do indeed need to make the change as it could be confusing for folks copy/pasting the example (as proven by our conversation on Discord). I have added the |
As part of #1219 we are reworking some of the code snippets of that page, we will address this issue as part of that work. |
this is addressed in PR #1229 |
|
What were you searching in the docs?
About the tracer.captureMethod() example of correct usage, actually the method is not support non-promise function.
Is this related to an existing documentation section?
https://awslabs.github.io/aws-lambda-powertools-typescript/latest/core/tracer/#methods
How can we improve?
It should change the example with show @tracer.captureMethod() in async - promise function.
Got a suggestion in mind?
No response
Acknowledgment
The text was updated successfully, but these errors were encountered: