Skip to content

Maintenance: Introduce workflow to add t-shirt size on PR #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Nov 13, 2022 · 3 comments · Fixed by #1167
Closed
1 of 2 tasks

Maintenance: Introduce workflow to add t-shirt size on PR #1164

dreamorosi opened this issue Nov 13, 2022 · 3 comments · Fixed by #1167
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

We'd like to automatically label PRs based on the amount of lines of code (LOC) that were changed.

Why is this needed?

This will help maintainers to better estimate the effort needed to review a given PR at a glance.

Which area does this relate to?

Automation

Solution

Automation should do this both on internal & external (i.e. from forks) PRs.

Acknowledgment

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) need-investigation discussing The issue needs to be discussed, elaborated, or refined labels Nov 13, 2022
@dreamorosi
Copy link
Contributor Author

Labels to be introduced are:

Label Usage Notes
size/XS PRs between 0-9 LOC PR automation
size/S PRs between 10-29 LOC PR automation
size/M PRs between 30-99 LOC PR automation
size/L PRs between 100-499 LOC PR automation
size/XL PRs between 500-999 LOC, often PRs that grown with feedback PR automation
size/XXL PRs with 1K+ LOC, largely documentation related PR automation

@dreamorosi dreamorosi added need-more-information Requires more information before making any calls and removed need-investigation labels Nov 13, 2022
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript Nov 14, 2022
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation automation This item relates to automation and removed discussing The issue needs to be discussed, elaborated, or refined need-more-information Requires more information before making any calls labels Nov 14, 2022
@dreamorosi dreamorosi self-assigned this Nov 14, 2022
@dreamorosi
Copy link
Contributor Author

dreamorosi commented Nov 14, 2022

I have enabled the pull-request-size bot that is already enabled for our org & is used by Powertools for Python as well:

image

The action is triggered on new and existing PRs when code changes.

The labels will be documented in a future PR.

@dreamorosi dreamorosi moved this from Working on it to Pending review in AWS Lambda Powertools for TypeScript Nov 14, 2022
@dreamorosi dreamorosi linked a pull request Nov 15, 2022 that will close this issue
13 tasks
Repository owner moved this from Pending review to Coming soon in AWS Lambda Powertools for TypeScript Nov 19, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Mar 2, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant