Skip to content

Maintenance: allow e2e test GitHub Action to run on #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Aug 24, 2022 · 1 comment · Fixed by #1079
Closed

Maintenance: allow e2e test GitHub Action to run on #1077

dreamorosi opened this issue Aug 24, 2022 · 1 comment · Fixed by #1079
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Description of the feature request

Problem statement

At the moment, every time a contributor opens a PR does that using a fork. The current implementation of the workflow that runs the e2e tests prevents us to run the tests from a fork because it allows us to select only branches of this repo.

In order to allow maintainers to run integration tests on PRs that come from the community, the workflow should be modified.

Summary of the feature

Similar to what done for the "Measure Package Size" workflow, the e2e test workflow should accept an optional parameter that represents a PR Number. This parameter could then be used to checkout the corresponding branch & run the e2e tests.

Note: this action should be performed by maintainers only after having thoroughly reviewed the contribution.

Code examples

See "Measure Package Size" workflow linked above.

Benefits for you and the wider AWS community
Contributors to this project could avoid having to run the e2e tests in their own accounts and potentially incurring in costs. On the maintainers' side instead, this change would result in less manual overhead (see alternatives considered below).

Describe alternatives you've considered
Continue operating like now, and require maintainers to checkout the branch locally, run the e2e tests, and then report the result on the PR.

Additional context
N/A

Related issues, RFCs

N/A

@dreamorosi dreamorosi added enhancement automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Aug 24, 2022
@dreamorosi dreamorosi self-assigned this Aug 24, 2022
@dreamorosi dreamorosi linked a pull request Aug 24, 2022 that will close this issue
8 tasks
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Aug 29, 2022
@dreamorosi dreamorosi removed the pending-release This item has been merged and will be released soon label Oct 27, 2022
@dreamorosi dreamorosi changed the title Feature (build): allow e2e test GitHub Action to run on Maintenance: allow e2e test GitHub Action to run on Nov 14, 2022
@dreamorosi dreamorosi added the completed This item is complete and has been merged/shipped label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
1 participant