Skip to content

Maintenance: release process is broken #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Aug 11, 2022 · 1 comment · Fixed by #1052
Closed

Maintenance: release process is broken #1050

dreamorosi opened this issue Aug 11, 2022 · 1 comment · Fixed by #1052
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Milestone

Comments

@dreamorosi
Copy link
Contributor

Bug description

Similar to what happened with #1046 the addition of the layer-publisher folder caused some issues with the release workflow making it fail.

Expected Behavior

The release process should carry on as expected.

Current Behavior

The new folder was added to the lerna context, so that every time a lerna ... command is run, that same command is also run in that folder. This is not an issue, but since we were not actually installing the dependencies of that folder the whole process would fail.

Possible Solution

Add a step that installs the dependencies.

Steps to Reproduce

Run the workflow.

Environment

  • Powertools version used: main
  • Packaging format (Layers, npm): N/A
  • AWS Lambda function runtime: N/A
  • Debugging logs: N/A

Related issues, RFCs

#826

@dreamorosi dreamorosi added the bug Something isn't working label Aug 11, 2022
@dreamorosi dreamorosi added this to the Lambda layer milestone Aug 11, 2022
@dreamorosi dreamorosi self-assigned this Aug 11, 2022
@dreamorosi dreamorosi linked a pull request Aug 11, 2022 that will close this issue
6 tasks
@dreamorosi dreamorosi added the automation This item relates to automation label Aug 11, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi changed the title Bug (layers): release process is broken Maintenance: release process is broken Nov 14, 2022
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) and removed bug Something isn't working labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant