Skip to content

Docs: create API docs #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Aug 4, 2022 · 3 comments · Fixed by #1283
Closed

Docs: create API docs #1043

dreamorosi opened this issue Aug 4, 2022 · 3 comments · Fixed by #1283
Assignees
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation parameters This item relates to the Parameters Utility

Comments

@dreamorosi
Copy link
Contributor

Description of the improvement

Summary of the proposal
As a part of our documentation we have a section that focuses on the APIs available. The new utility should feature docstrings that will then populate the corresponding pages of this documentation.

How, where did you look for information
This unit of work tracks the activities related to having the API docs for the new utility. On an high level, these are:

  • Create docstrings for each class / method / function
  • Review content accuracy & wording
  • Review visually the docs locally

Missing or unclear documentation
https://awslabs.github.io/aws-lambda-powertools-typescript/latest/api/modules/_aws_lambda_powertools_parameters.html

Improvement
N/A

Related existing documentation

[N/A](https://awslabs.github.io/aws-lambda-powertools-typescript/latest/api/

Related issues, RFCs

#846

@dreamorosi dreamorosi added documentation Improvements or additions to documentation triage This item has not been triaged by a maintainer, please wait parameters This item relates to the Parameters Utility labels Aug 4, 2022
@dreamorosi dreamorosi added this to the Parameters milestone Aug 4, 2022
@saragerion saragerion added the good-first-issue Something that is suitable for those who want to start contributing label Sep 8, 2022
@dreamorosi dreamorosi assigned dreamorosi and unassigned dreamorosi Oct 19, 2022
@dreamorosi dreamorosi removed the good-first-issue Something that is suitable for those who want to start contributing label Oct 27, 2022
@dreamorosi dreamorosi removed the triage This item has not been triaged by a maintainer, please wait label Nov 13, 2022
@dreamorosi dreamorosi moved this from Backlog to On hold in AWS Lambda Powertools for TypeScript Nov 13, 2022
@dreamorosi dreamorosi added the on-hold This item is on-hold and will be revisited in the future label Nov 13, 2022
@dreamorosi dreamorosi moved this from On hold to Backlog in AWS Lambda Powertools for TypeScript Nov 13, 2022
@dreamorosi dreamorosi changed the title Documentation (parameters): create API docs Docs: create API docs Nov 14, 2022
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed on-hold This item is on-hold and will be revisited in the future labels Jan 6, 2023
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript Jan 7, 2023
@dreamorosi dreamorosi self-assigned this Jan 7, 2023
@dreamorosi dreamorosi added blocked This item's progress is blocked by external dependency or reason and removed confirmed The scope is clear, ready for implementation labels Jan 7, 2023
@dreamorosi
Copy link
Contributor Author

I'm having issues with generating the API docs for all the providers given that they are not all exported at the main package index.

Opened an issue on the TypeStrong repo:
TypeStrong/typedoc#2138

@dreamorosi
Copy link
Contributor Author

It seems that it's not possible to have multiple entry points and so, in order to have the documentation, we'll have to export all providers from the main src/index.ts.

I did some tests both with esbuild and tsc and as long as using scoped imports like (note ending):

import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm';

It seems to work without throwing missing dependency errors for the other providers.

@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed blocked This item's progress is blocked by external dependency or reason labels Feb 8, 2023
@dreamorosi dreamorosi linked a pull request Feb 9, 2023 that will close this issue
13 tasks
@dreamorosi dreamorosi moved this from Working on it to Pending review in AWS Lambda Powertools for TypeScript Feb 27, 2023
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in AWS Lambda Powertools for TypeScript Mar 16, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Mar 16, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Mar 17, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped documentation Improvements or additions to documentation parameters This item relates to the Parameters Utility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants