Skip to content

Maintenance: integrate utility with CI/CD merge process #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Aug 4, 2022 · 2 comments
Closed

Maintenance: integrate utility with CI/CD merge process #1041

dreamorosi opened this issue Aug 4, 2022 · 2 comments
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped parameters This item relates to the Parameters Utility

Comments

@dreamorosi
Copy link
Contributor

Description of the feature request

Problem statement
Every time a PR is merged a number of checks and actions are run on the utilities to make sure that the changes introduced are compatible with the existing code (this is somewhat redundant as these same checks also run in the PR itself - but better be safe than sorry).

Additionally, the workflow that runs on merge also builds the documentation and API docs and publishes it.

Summary of the feature
This unit of work tracks the activities and changes needed for the new utility to be part of the merge workflow.

Code examples
N/A

Benefits for you and the wider AWS community
N/A

Describe alternatives you've considered
N/A

Additional context
N/A

Related issues, RFCs

#846

@dreamorosi dreamorosi added triage This item has not been triaged by a maintainer, please wait automation This item relates to automation parameters This item relates to the Parameters Utility labels Aug 4, 2022
@dreamorosi dreamorosi added this to the Parameters milestone Aug 4, 2022
@dreamorosi dreamorosi added on-hold This item is on-hold and will be revisited in the future and removed triage This item has not been triaged by a maintainer, please wait labels Nov 13, 2022
@dreamorosi dreamorosi moved this from On hold to Backlog in AWS Lambda Powertools for TypeScript Nov 13, 2022
@dreamorosi dreamorosi changed the title Feature (parameters): integrate utility with CI/CD merge process Maintenance: integrate utility with CI/CD merge process Nov 14, 2022
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed on-hold This item is on-hold and will be revisited in the future labels Jan 10, 2023
@dreamorosi dreamorosi self-assigned this Jan 10, 2023
@dreamorosi dreamorosi moved this from Backlog to Coming soon in AWS Lambda Powertools for TypeScript Jan 10, 2023
@dreamorosi
Copy link
Contributor Author

Linting & testing is already being run as part of the merge workflow. Likewise, now the docs have been merged the file is already picked up (although not present in the navbar). The API docs would already pick up the new utility, however due to this line, it's currently explicitly excluded.

Closing this issue as completed.

@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped parameters This item relates to the Parameters Utility
Projects
None yet
Development

No branches or pull requests

1 participant