Skip to content

Maintenance: integrate utility with CI/CD unit test processes #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamorosi opened this issue Aug 2, 2022 · 2 comments
Closed

Maintenance: integrate utility with CI/CD unit test processes #1035

dreamorosi opened this issue Aug 2, 2022 · 2 comments
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped parameters This item relates to the Parameters Utility

Comments

@dreamorosi
Copy link
Contributor

Description of the feature request

Problem statement
Even if the new utility won't be released till much later, whenever code is merged into main the code coverage should stay at 100%.

Summary of the feature
This unit of work tracks the activities and changes needed for the parameters utility to be part of the unit test workflows that run whenever a PR is created and/or updated.

Additionally, the new utility should also be part of the husky hooks that are ran locally before committing.

Code examples
N/A

Benefits for you and the wider AWS community
N/A

Describe alternatives you've considered
None, tests must be there.

Additional context
N/A

Related issues, RFCs

#846

@dreamorosi dreamorosi added triage This item has not been triaged by a maintainer, please wait parameters This item relates to the Parameters Utility labels Aug 2, 2022
@dreamorosi dreamorosi added this to the Parameters milestone Aug 2, 2022
@dreamorosi dreamorosi added on-hold This item is on-hold and will be revisited in the future and removed triage This item has not been triaged by a maintainer, please wait labels Nov 13, 2022
@dreamorosi dreamorosi moved this from On hold to Backlog in AWS Lambda Powertools for TypeScript Nov 13, 2022
@dreamorosi dreamorosi added the automation This item relates to automation label Nov 13, 2022
@dreamorosi dreamorosi changed the title Feature (parameters): integrate utility with CI/CD unit test processes Maintenance: integrate utility with CI/CD unit test processes Nov 14, 2022
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript Jan 6, 2023
@dreamorosi dreamorosi self-assigned this Jan 6, 2023
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed on-hold This item is on-hold and will be revisited in the future labels Jan 6, 2023
@dreamorosi
Copy link
Contributor Author

Unit tests on for the Parameters utility are now run every time a PR is updated and also after each merge to main.

This is the line that calls it in the reusable-run-linting-check-and-unit-tests workflow.

@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript Jan 6, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped parameters This item relates to the Parameters Utility
Projects
None yet
Development

No branches or pull requests

1 participant