Skip to content

Commit fba2423

Browse files
authored
chore(maintenance): remove eslint & prettier (#2841)
1 parent 76138bf commit fba2423

File tree

21 files changed

+84
-2254
lines changed

21 files changed

+84
-2254
lines changed

.devcontainer/devcontainer.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
"customizations": {
1515
// Add the ids of extensions you want installed when the container is created.
1616
"extensions": [
17-
"dbaeumer.vscode-eslint",
18-
"esbenp.prettier-vscode",
17+
"biomejs.biome",
1918
"firsttris.vscode-jest-runner"
2019
],
2120
"vscode": {

.eslintignore

-4
This file was deleted.

.eslintrc.js

-72
This file was deleted.

.github/boring-cyborg.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ labelPRBasedOnFilePath:
9595
- LICENSE-THIRD-PARTY
9696
- lerna.json
9797
- .nvmrc
98-
- .eslintrc.cjs
99-
- .eslintignore
98+
- .biome.json
10099
- .npmignore
101100
- .gitpod.yml
102101
- .husky/*

.gitpod.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@ tasks:
99
npm run setup-local
1010
vscode:
1111
extensions:
12-
- dbaeumer.vscode-eslint
13-
- esbenp.prettier-vscode
12+
- biomejs.biome
1413
- firsttris.vscode-jest-runner

.prettierrc

-8
This file was deleted.

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ You might find useful to run both the documentation website and the API referenc
126126
| Category | Convention |
127127
| --------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
128128
| **Docstring** | We use [TypeDoc](https://typedoc.org) annotations to help generate more readable API references. For public APIs, we always include at least one **Example** to ease everyone's experience when using an IDE. |
129-
| **Style guide** | We use [Eslint](https://eslint.org) and [Prettier](https://prettier.io) to enforce beyond good practices. We use TypeScript types, function return types, and access modifiers to convey intent. |
129+
| **Style guide** | We use [Biome](http://biomejs.dev) to enforce style and format beyond good practices. We use TypeScript types, function return types, and access modifiers to convey intent. |
130130
| **Core utilities** | Core utilities always accept `serviceName` as a constructor parameter, can work in isolation, and are also available in other languages implementation. |
131131
| **Utilities** | Utilities are not as strict as core and focus on community needs: development productivity, industry leading practices, etc. Both core and general utilities follow our [Tenets](https://docs.powertools.aws.dev/lambda/typescript/#tenets). |
132132
| **Errors** | Specific errors thrown by Powertools live within utilities themselves and use `Error` suffix e.g. `IdempotencyKeyError`. |

docs/contributing/conventions.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ As we gather more concrete examples, this page will have one section for each ca
1414
| Category | Convention |
1515
| --------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
1616
| **Docstring** | We use [TypeDoc](https://typedoc.org){target="_blank"} annotations to help generate more readable API references. For public APIs, we always include at least one **Example** to ease everyone's experience when using an IDE. |
17-
| **Style guide** | We use [Eslint](https://eslint.org){target="_blank"} and [Prettier](https://prettier.io){target="_blank"} to enforce beyond good practices. We use TypeScript types, function return types, and access modifiers to convey intent. |
17+
| **Style guide** | We use [Biome](http://biomejs.dev){target="_blank"} for linting and formatting to enforce beyond good practices. We use TypeScript types, function return types, and access modifiers to convey intent. |
1818
| **Core utilities** | Core utilities always accept `serviceName` as a constructor parameter, can work in isolation, and are also available in other languages implementation. |
1919
| **Utilities** | Utilities are not as strict as core and focus on community needs: development productivity, industry leading practices, etc. Both core and general utilities follow our [Tenets](https://docs.powertools.aws.dev/lambda/typescript/#tenets){target="_blank"}. |
2020
| **Errors** | Specific errors thrown by Powertools live within utilities themselves and use `Error` suffix e.g. `IdempotencyKeyError`. |

examples/app/functions/commons/helpers/utils.ts

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
*
1010
* @param error The value to assert is an error
1111
*/
12-
// eslint-disable-next-line func-style -- type assertions cannot use arrow functions microsoft/TypeScript#34523
1312
function assertIsError(error: unknown): asserts error is Error {
1413
if (!(error instanceof Error)) {
1514
throw error;

layers/tests/e2e/layerPublisher.test.ts

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import {
2323

2424
jest.spyOn(console, 'log').mockImplementation();
2525

26-
// eslint-disable-next-line func-style -- type assertions can't be arrow functions
2726
function assertLogs(
2827
logs: TestInvocationLogs | undefined
2928
): asserts logs is TestInvocationLogs {

0 commit comments

Comments
 (0)