Skip to content

Commit e5454c9

Browse files
committed
fix: update terminology from "handler" to "resolver" in RouteHandlerRegistry and related tests
1 parent 1342ca4 commit e5454c9

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/event-handler/src/appsync-graphql/RouteHandlerRegistry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class RouteHandlerRegistry {
3030
}
3131

3232
/**
33-
* Registers a new GraphQL route handler for a specific type and field.
33+
* Registers a new GraphQL route resolver for a specific type and field.
3434
*
3535
* @param options - The options for registering the route handler, including the GraphQL type name, field name, and the handler function.
3636
* @param options.fieldName - The field name of the GraphQL type to be registered
@@ -46,7 +46,7 @@ class RouteHandlerRegistry {
4646
const cacheKey = this.#makeKey(typeName, fieldName);
4747
if (this.resolvers.has(cacheKey)) {
4848
this.#logger.warn(
49-
`A route handler for field '${fieldName}' is already registered for '${typeName}'. The previous handler will be replaced.`
49+
`A resolver for field '${fieldName}' is already registered for '${typeName}'. The previous resolver will be replaced.`
5050
);
5151
}
5252
this.resolvers.set(cacheKey, {

packages/event-handler/tests/unit/appsync-graphql/RouteHandlerRegistry.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ describe('Class: RouteHandlerRegistry', () => {
3434
}
3535
);
3636

37-
it('logs a warning and replaces the previous handler if the field & type is already registered', () => {
37+
it('logs a warning and replaces the previous resolver if the field & type is already registered', () => {
3838
// Prepare
3939
const registry = getRegistry();
4040
const originalHandler = vi.fn();
@@ -60,11 +60,11 @@ describe('Class: RouteHandlerRegistry', () => {
6060
handler: otherHandler,
6161
});
6262
expect(console.warn).toHaveBeenCalledWith(
63-
"A route handler for field 'getPost' is already registered for 'Query'. The previous handler will be replaced."
63+
"A resolver for field 'getPost' is already registered for 'Query'. The previous resolver will be replaced."
6464
);
6565
});
6666

67-
it('will not replace the handler if the event type is different', () => {
67+
it('will not replace the resolver if the event type is different', () => {
6868
// Prepare
6969
const registry = getRegistry();
7070
const originalHandler = vi.fn();

0 commit comments

Comments
 (0)