fix: remove reduntant methods

Author: dreamorosi

Diff for: packages/commons/src/config/ConfigService.ts

@@ -9,12 +9,6 @@
  */
 abstract class ConfigService {
 
-  /**
-   * @see https://awslabs.github.io/aws-lambda-powertools-typescript/latest/#environment-variables
-   * @protected
-   */
-  protected serviceNameVariable = 'POWERTOOLS_SERVICE_NAME';
-
   /**
    * It returns the value of an environment variable that has given name.
    *

Diff for: packages/commons/src/config/EnvironmentVariablesService.ts

@@ -15,6 +15,11 @@ import { ConfigService } from '.';
  */
 class EnvironmentVariablesService extends ConfigService {
 
+  /**
+   * @see https://awslabs.github.io/aws-lambda-powertools-typescript/latest/#environment-variables
+   * @protected
+   */
+  protected serviceNameVariable = 'POWERTOOLS_SERVICE_NAME';
   // Reserved environment variables
   private xRayTraceIdVariable = '_X_AMZN_TRACE_ID';
 

Diff for: packages/logger/src/config/EnvironmentVariablesService.ts

@@ -105,24 +105,6 @@ class EnvironmentVariablesService extends CommonEnvironmentVariablesService impl
     return (value && value.length > 0) ? Number(value) : undefined;
   }
 
-  /**
-   * It returns the value of the POWERTOOLS_SERVICE_NAME environment variable.
-   *
-   * @returns {string}
-   */
-  public getServiceName(): string {
-    return this.get(this.serviceNameVariable);
-  }
-
-  /**
-   * It returns the value of the _X_AMZN_TRACE_ID environment variable.
-   *
-   * @returns {string}
-   */
-  public getXrayTraceId(): string {
-    return super.getXrayTraceId();
-  }
-
 }
 
 export {

Diff for: packages/metrics/src/Metrics.ts

@@ -450,8 +450,8 @@ class Metrics extends Utility implements MetricsInterface {
 
   private setService(service: string | undefined): void {
     const targetService = (service ||
-      this.getCustomConfigService()?.getService() ||
-      this.getEnvVarsService().getService()) as string;
+      this.getCustomConfigService()?.getServiceName() ||
+      this.getEnvVarsService().getServiceName()) as string;
     if (targetService.length > 0) {
       this.addDimension('service', targetService);
     }

Diff for: packages/metrics/src/config/ConfigServiceInterface.ts

@@ -2,7 +2,7 @@ interface ConfigServiceInterface {
 
   get?(name: string): string
   getNamespace(): string
-  getService(): string
+  getServiceName(): string
 
 }
 

Diff for: packages/metrics/src/config/EnvironmentVariablesService.ts

@@ -4,18 +4,10 @@ import { EnvironmentVariablesService as CommonEnvironmentVariablesService } from
 class EnvironmentVariablesService extends CommonEnvironmentVariablesService implements ConfigServiceInterface {
 
   private namespaceVariable = 'POWERTOOLS_METRICS_NAMESPACE';
-  private serviceVariable = 'POWERTOOLS_SERVICE_NAME';
-
-  public get(name: string): string {
-    return process.env[name]?.trim() || '';
-  }
 
   public getNamespace(): string {
     return this.get(this.namespaceVariable);
   }
-  public getService(): string {
-    return this.get(this.serviceVariable);
-  }
 
 }
 

Diff for: packages/metrics/tests/unit/Metrics.test.ts

@@ -684,7 +684,7 @@ describe('Class: Metrics', () => {
       const serviceName = 'Custom Provider Service Name';
       const namespace = 'Custom Provider namespace';
       const customConfigService = {
-        getService: () => serviceName,
+        getServiceName: () => serviceName,
         getNamespace: () => namespace,
       };
 

Diff for: packages/tracer/src/config/EnvironmentVariablesService.ts

@@ -11,10 +11,6 @@ class EnvironmentVariablesService extends CommonEnvironmentVariablesService impl
   private tracerCaptureResponseVariable = 'POWERTOOLS_TRACER_CAPTURE_RESPONSE';
   private tracingEnabledVariable = 'POWERTOOLS_TRACE_ENABLED';
 
-  public get(name: string): string {
-    return process.env[name]?.trim() || '';
-  }
-
   public getAwsExecutionEnv(): string {
     return this.get(this.awsExecutionEnv);
   }
@@ -27,10 +23,6 @@ class EnvironmentVariablesService extends CommonEnvironmentVariablesService impl
     return this.get(this.samLocalVariable);
   }
 
-  public getServiceName(): string {
-    return this.get(this.serviceNameVariable);
-  }
-
   public getTracingCaptureError(): string {
     return this.get(this.tracerCaptureErrorVariable);
   }
@@ -43,9 +35,6 @@ class EnvironmentVariablesService extends CommonEnvironmentVariablesService impl
     return this.get(this.tracingEnabledVariable);
   }
 
-  public getXrayTraceId(): string {
-    return super.getXrayTraceId();
-  }
 }
 
 export {