test(logger): expect lambda handler to throw in unit tests for clear state functionality

Author: saragerion

Diff for: packages/logger/tests/unit/Logger.test.ts

@@ -982,7 +982,7 @@ describe('Class: Logger', () => {
 
     });
 
-    test('when used as decorator with the clear state flag enabled and the handler throws, the persistent log attributes added in the handler are removed after the handler\'s code is executed', async () => {
+    test('when used as decorator with the clear state flag enabled and the handler throws an error, the persistent log attributes added in the handler are removed after the handler\'s code is executed', async () => {
 
       // Prepare
       const logger = new Logger({
@@ -1014,15 +1014,12 @@ describe('Class: Logger', () => {
 
       const persistentAttribs = { ...logger.getPersistentLogAttributes() };
 
-      // Act
-      try {
+      // Act & Assess
+      const executeLambdaHandler = async (): Promise<void> => {
         await new LambdaFunction().handler({ user_id: '123456' }, dummyContext, () => console.log('Lambda invoked!'));
-      } catch (error) {
-        // Do nothing
-      }
+      };
+      await expect(executeLambdaHandler()).rejects.toThrow('Unexpected error occurred!');
       const persistentAttribsAfterInvocation = { ...logger.getPersistentLogAttributes() };
-
-      // Assess
       expect(persistentAttribs).toEqual({
         foo: 'bar',
         biz: 'baz'

Diff for: packages/logger/tests/unit/middleware/middy.test.ts

@@ -10,6 +10,7 @@ import { Logger } from './../../../src';
 import middy from '@middy/core';
 import { PowertoolLogFormatter } from '../../../src/formatter';
 import { Console } from 'console';
+import { context as dummyContext } from '../../../../../tests/resources/contexts/hello-world';
 
 const mockDate = new Date(1466424490000);
 const dateSpy = jest.spyOn(global, 'Date').mockImplementation(() => mockDate as unknown as string);
@@ -207,7 +208,7 @@ describe('Middy middleware', () => {
 
     });
 
-    test('when enabled and the handler throws, the persistent log attributes added within the handler scope are removed after the invocation ends', async () => {
+    test('when enabled and the handler throws an error, the persistent log attributes added within the handler scope are removed after the invocation ends', async () => {
 
       // Prepare
       const logger = new Logger({
@@ -243,18 +244,15 @@ describe('Middy middleware', () => {
         throw new Error('Unexpected error occurred!');
       };
 
-      const handler = middy(lambdaHandler).use(injectLambdaContext(logger, { clearState: true }));
       const persistentAttribs = { ...logger.getPersistentLogAttributes() };
+      const handler = middy(lambdaHandler).use(injectLambdaContext(logger, { clearState: true }));
 
-      // Act
-      try {
+      // Act & Assess
+      const executeLambdaHandler = async (): Promise<void> => {
         await handler({ user_id: '123456' }, context, () => console.log('Lambda invoked!'));
-      } catch (error) {
-        // Do nothing
-      }
+      };
+      await expect(executeLambdaHandler()).rejects.toThrow('Unexpected error occurred!');
       const persistentAttribsAfterInvocation = { ...logger.getPersistentLogAttributes() };
-
-      // Assess
       expect(persistentAttribs).toEqual({
         foo: 'bar',
         biz: 'baz'