Skip to content

Commit 973a9d5

Browse files
authored
Update CONTRIBUTING.md
1 parent 4f62c1a commit 973a9d5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Diff for: CONTRIBUTING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,11 @@ You can run the end-to-end tests automatically on your forked project by followi
142142

143143
- [Github OpenID Connect](https://github.blog/changelog/2021-10-27-github-actions-secure-cloud-deployments-with-openid-connect/
144144
- ["Configure AWS Credentials" Action For GitHub Actions](https://github.com/aws-actions/configure-aws-credentials/)
145-
1. Add your new role into your [Github fork secrets](https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository) with name `AWS_ROLE_ARN_TO_ASSUME`.
146-
1. In your forked repository, go to the "Actions" tabs, select the `run-e2e-tests` workflow.
147-
1. In the run-e2e-tests workflow page, select "Run workflow" and run it on the desired branch.
145+
2. Add your new role into your [Github fork secrets](https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository) with name `AWS_ROLE_ARN_TO_ASSUME`.
146+
3. In your forked repository, go to the "Actions" tabs, select the `run-e2e-tests` workflow.
147+
4. In the run-e2e-tests workflow page, select "Run workflow" and run it on the desired branch.
148148

149-
> :Warning: **Don't automatically run end-to-end tests on branch push or PRs**. A malicious attacker can submit a pull request to attack your AWS account. Ideally, use a blank account without any important workload/data, and limit `AWS_ROLE_ARN_TO_ASSUME` permission to least minimum privilege.
149+
> :warning: **Don't automatically run end-to-end tests on branch push or PRs**. A malicious attacker can submit a pull request to attack your AWS account. Ideally, use a blank account without any important workload/data, and limit `AWS_ROLE_ARN_TO_ASSUME` permission to least minimum privilege.
150150
### Conventions
151151

152152
Category | Convention
@@ -179,4 +179,4 @@ TODO
179179

180180
See the [LICENSE](LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution.
181181

182-
We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.
182+
We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.

0 commit comments

Comments
 (0)