Skip to content

Commit 7eb3782

Browse files
committed
chore: address review feedback
1 parent 55a2b1e commit 7eb3782

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

packages/logger/tests/unit/configFromEnv.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ describe('Class: EnvironmentVariablesService', () => {
2323
const value = service.getAwsLogLevel();
2424

2525
// Assess
26+
// The Advanced Logging Controls feature in AWS Lambda supports the `FATAL` log leve, which we don't support
27+
// and instead map to `CRITICAL` as per the existing log levels. In this test, we expect the value to be `CRITICAL`.
2628
expect(value).toEqual('CRITICAL');
2729
});
2830

packages/logger/tests/unit/injectLambdaContext.test.ts

-6
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,6 @@ describe('Inject Lambda Context', () => {
6969

7070
// Assess
7171
expect(logSpy).toHaveBeenCalledTimes(2);
72-
expect(JSON.parse(logSpy.mock.calls[0][0])).toStrictEqual(
73-
expect.objectContaining({
74-
message: 'Hello, world!',
75-
...getContextLogEntries(),
76-
})
77-
);
7872
expect(JSON.parse(logSpy.mock.calls[1][0])).toStrictEqual(
7973
expect.objectContaining({
8074
message: 'Hello, world!',

0 commit comments

Comments
 (0)